Skip to content

fix: stop ISBN-10/ISSN digits from truncating EAN-13 payload #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santhreal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop ISBN-10/ISSN digits from truncating EAN-13 payload #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b2a610
fix: stop ISBN-10/ISSN digits from truncating EAN-13 payload
santhreal Jul 18, 2026
f56f1fe
style: align ISBN-10 fullcode comment with isbn_digits
santhreal Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions barcode/isxn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ class InternationalStandardBookNumber10(InternationalStandardBookNumber13):

name = "ISBN-10"

digits = 9
isbn_digits = 9

def __init__(self, isbn, writer=None) -> None:
isbn = isbn.replace("-", "")
isbn = isbn[: self.digits]
isbn = isbn[: self.isbn_digits]
super().__init__("978" + isbn, writer)
self.isbn10 = isbn
self.isbn10 = f"{isbn}{self._calculate_checksum()}"
Expand Down Expand Up @@ -99,11 +99,11 @@ class InternationalStandardSerialNumber(EuropeanArticleNumber13):

name = "ISSN"

digits = 7
issn_digits = 7

def __init__(self, issn, writer=None) -> None:
issn = issn.replace("-", "")
issn = issn[: self.digits]
issn = issn[: self.issn_digits]
self.issn = issn
self.issn = f"{issn}{self._calculate_checksum()}"
super().__init__(self.make_ean(), writer)
Expand Down
3 changes: 3 additions & 0 deletions tests/test_checksums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ def test_ean14_checksum() -> None:
def test_isbn10_checksum() -> None:
isbn = get_barcode("isbn10", "376926085")
assert isbn.isbn10 == "3769260856" # type: ignore[attr-defined]
# ISBN-10 renders as EAN-13; isbn_digits must not shadow EAN digits.
assert isbn.get_fullcode() == "9783769260854"


def test_isbn13_checksum() -> None:
Expand All @@ -53,6 +55,7 @@ def test_issn_checksum_zero() -> None:
# not 11. Regression test for issue #238.
issn = get_barcode("issn", "6727893")
assert issn.issn == "67278930" # type: ignore[attr-defined]
assert issn.get_fullcode() == "9776727893003"


def test_issn_checksum_x() -> None:
Expand Down