Fix 64-bit safe integer boundary checks - #9074
Open
GtechGovind wants to merge 1 commit into
Open
Conversation
kripken
reviewed
Sep 4, 2026
| EXPECT_TRUE(wasm::isSInteger64(-0x1p63)); | ||
| EXPECT_TRUE(wasm::isSInteger64(std::nextafter(0x1p63, 0.0))); | ||
| EXPECT_FALSE(wasm::isSInteger64(0x1p63)); | ||
| } |
Member
There was a problem hiding this comment.
Which of these tests fail before the fix?
Author
There was a problem hiding this comment.
Before the fix, these two assertions fail:
- EXPECT_FALSE(wasm::isUInteger64(0x1p64))
- EXPECT_FALSE(wasm::isSInteger64(0x1p63))
The previous upper-bound conversions round UINT64_MAX and INT64_MAX to 2^64 and 2^63 respectively, so those out-of-range values were incorrectly accepted. The other boundary assertions pass before the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INT64_MAXandUINT64_MAXto out-of-rangedoublevaluesCloses #2291.
Testing
./out/build/bin/binaryen-unittests --gtest_filter=SafeInteger.*(2 passed)./out/build/bin/binaryen-unittests(422 passed)