[wasm-ctor-eval] Avoid local and global state getting out of sync#8776
Open
kripken wants to merge 8 commits into
Open
[wasm-ctor-eval] Avoid local and global state getting out of sync#8776kripken wants to merge 8 commits into
kripken wants to merge 8 commits into
Conversation
tlively
reviewed
May 26, 2026
Comment on lines
+535
to
+537
| // information into the module. This must be done before we start to serialize | ||
| // content. After this, serialization can happen, and after that, a call to | ||
| // applyToModule() can be done. |
Member
There was a problem hiding this comment.
Can you explain more why "this must be done before we start to serialize content?"
|
|
||
| // We are about to serialize content (the code paths below call | ||
| // getSerialization). Clear the state. | ||
| interface.clearApplyState(); |
Member
There was a problem hiding this comment.
Can we make it so getSerialization automatically calls this as necessary?
Comment on lines
+31
to
+33
| (drop | ||
| (global.get $gimport) | ||
| ) |
Member
There was a problem hiding this comment.
Is it expected that this global.get is absent in the output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify this by clearing before any serialization. Before, if we partially
evalled, the local and global state could diverge, leading to locals
referring to the wrong globals.
Changes to the existing test are NFC, just reordering of names (sadly).