Fix deleting a numbered-list item removing following items (#18)#25
Merged
Conversation
When a single newline was deleted to merge two lines, RichSpanManager did not remap spans living entirely below the joined line, so they kept stale line indices and were dropped. Deleting a middle ordered-list item therefore removed every following item from the list. Decrement those spans' line indices to follow the upward line shift. Fixes #18 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a numbered-list item in the middle dropped every following item from the list.
Root cause
In
RichSpanManager's single-newline delete branch (line merge), spans living entirely below the joined line were never re-added to the updated span set and kept stale line indices, so they were dropped. For an ordered list, deleting/merging a middle item removed every following item'sOrderedListSpanStyle. (The multi-line delete path already decrements following-line offsets viatransformOffset; only the newline-merge path was broken.)Fix
Add the missing case: spans entirely below the joined line have their start/end line index decremented by one to follow the upward shift.
Tests
deleting a middle ordered-list item keeps following items in the list(inmarkdown.OrderedListSerializationTest) — fails before, passes after.:ComposeTextEditor:desktopTest— 430 tests, 0 failures.Fixes #18