Skip to content

fix(ci): drop @semantic-release/git + changelog, GH006 blocks direct push to protected main - #43

Merged
asachs01 merged 1 commit into
mainfrom
fix/gh006-drop-semantic-release-git
Sep 18, 2026
Merged

asachs01 merged 1 commit into
mainfrom
fix/gh006-drop-semantic-release-git

Conversation

@asachs01

@asachs01 asachs01 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Problem

node-auvik#42's Release run (merge e6fb5652) correctly computed next version 1.3.3 but failed at @semantic-release/git's prepare step: it pushes a version-bump commit + tags directly to main, which required_pull_request_reviews branch protection now rejects (GH006: Changes must be made through a pull request). No tag/release was created.

Fix

Drop @semantic-release/git and @semantic-release/changelog (the changelog file write is orphaned once nothing commits it back to the branch). Keep @semantic-release/npm + @semantic-release/github, which publish via API/registry calls rather than a direct git push.

Same root cause and proven fix already shipped on alternative-payments-mcp#18 and threatlocker-mcp#44 — part of the Aaron-approved 57-repo fleet rollout (task_1786452397590_72268711), of which this repo was apparently missed.

Verification plan

Once merged, the next release-eligible push should complete Release end-to-end (tag + GitHub Release created) with no push-to-main step in the pipeline at all.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated release automation to publish packages and GitHub releases without generating changelog files or automatically updating release-related files.

…push to protected main

@semantic-release/git's prepare step pushes a version-bump commit + tags directly
to main via git push, which required_pull_request_reviews branch protection now
rejects (GH006: 'Changes must be made through a pull request'). Confirmed live:
node-auvik#42's Release run computed the next version correctly (1.3.3) but failed
at the git push step, so no tag/release was ever created.

Same root cause and fix already proven on alternative-payments-mcp#18 and
threatlocker-mcp#44 (task_1786452397590_72268711, Aaron-approved 2026-08-11,
57-repo fleet rollout): drop @semantic-release/git and @semantic-release/changelog
(the changelog file write is orphaned once nothing commits it back), keep
@semantic-release/npm + @semantic-release/github, which publish via API/registry
calls rather than a direct push to the protected branch.
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6a371795-af2b-4403-a779-7195c1c38bd6

📥 Commits

Reviewing files that changed from the base of the PR and between e6fb565 and 9b3f934.

📒 Files selected for processing (1)
  • .releaserc.json
 ____________________________________________________________________________________________________________________________________________
< Every great developer you know got there by solving problems they were unqualified to solve until they actually did it. - Patrick McKenzie >
 --------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@wyre-agent-fleet wyre-agent-fleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: this fix is byte-identical in shape to the already-merged alternative-payments-mcp#18 / threatlocker-mcp#44 (drop @semantic-release/git + changelog, keep npm+github). Confirmed live: node-auvik's Release run on e6fb565 computed v1.3.3 correctly via commit-analyzer but failed at the git-push step with GH006 (branch protection). No tag/release exists yet. node-auvik's release.yml already uses the two-job split from #41 (no npm install happens in the write-scoped release job), so this PR alone is the complete fix here -- no separate .npmrc change needed for this repo.

@asachs01
asachs01 merged commit 37cac8b into main Sep 18, 2026
3 of 4 checks passed
@asachs01
asachs01 deleted the fix/gh006-drop-semantic-release-git branch September 18, 2026 16:41
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant