[IOS-8204] Android/iOS package 7.0.2: clickable native ad views, lifecycle fixes, repo restructure - #71
Open
stanley-vungle wants to merge 1 commit into
Open
[IOS-8204] Android/iOS package 7.0.2: clickable native ad views, lifecycle fixes, repo restructure#71stanley-vungle wants to merge 1 commit into
stanley-vungle wants to merge 1 commit into
Conversation
stanley-vungle
requested review from
ManojBudumuru-vungle,
ashinagawa and
crbinsf
July 24, 2026 22:20
stanley-vungle
force-pushed
the
IOS-8204
branch
2 times, most recently
from
July 24, 2026 22:22
70b45e2 to
3b2cb19
Compare
…2 and test app Repo restructure (Packages/ paths unchanged so publisher UPM references keep working): - Windows/ — C++ bridge source and WindowsSDK7SampleApp, with platform README - AndroidIOS/ — new VungleSDKSampleApp test app, with platform README - Root LICENSE.md updated to the LMI/Monetize license matching the package; root README maps the layout Package io.liftoff.vungleads 7.0.2 (mirrored from the private vungle-unity-plugIn repo via its sync-package-to-public.sh): - Native ads: selectable clickable views — Attach overloads take a media rect plus clickable rects/RectTransforms; each becomes a transparent native view registered with the SDK, so publishers choose exactly which app-rendered elements count as ad clicks (the SDK only defaults the media view to clickable when no list is given) - Lifecycle: Destroy() unregisters and releases ad assets with a finalizer safety net; Detach() stays lightweight and re-attachable; fixes view and reference leaks on both platforms - Fix Android crashes on destroy and on re-attach with a changed clickable set (the SDK fires onAdEnd synchronously from unregisterView; same-root re-registration is a silent no-op, so changed sets rebuild fresh views) - Fix iOS phantom clicks on Unity UI: the ad container swallows touches (Unity normalizes forwarded touches by the originating view's bounds) - Fix attach-before-load wedging the bridge: fail fast via onPresentFailed; failed registrations clear bridge state - Removed: per-frame position tracking for native ads and banners (breaking: the banner track option shipped in 7.0.0) — the native overlay renders above all Unity UI and cannot be clipped by Unity viewports - Android SDK dependency widened to com.vungle:vungle-ads:[7.7,8.0) to match the iOS pod's "~> 7.7" - CHANGELOG: 7.0.2 entries plus backfilled 7.0.1 (Asset Store availability) Test app: - Sample scenes for all ad formats; CTA Configuration dialog with per-element clickable toggles; DualNative whole-card clickable - EDM4U gradle templates, TMP Essential Resources, dynamic OS-font fallbacks for international ad text - iOS Script Call Optimization set to produce hard crash logs on device Device-verified on Android and the iOS Simulator: load/attach/detach/ re-attach flows, clickable-set changes, destroy-on-reload, scene exits, and all previously crashing repros. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the
io.liftoff.vungleads7.0.2 release and restructures this MSFT-facing repo by platform.Repo restructure
Windows/(C++ bridge + sample app) andAndroidIOS/(newVungleSDKSampleApptest app);Packages/paths unchanged so publisher UPM references keep workingLICENSE.mdupdated to the LMI/Monetize license matching the package; per-platform READMEsio.liftoff.vungleadsmirrored from the privatevungle-unity-plugInrepo via its newsync-package-to-public.shPackage 7.0.2 (mirrored)
Attachoverloads take a media rect plus clickable rects/RectTransforms; each becomes a transparent native view registered with the SDK, so publishers choose exactly which app-rendered elements count as ad clicksDestroy()(unregisters + releases ad assets; finalizer safety net) vs. lightweight re-attachableDetach(); fixes view/reference leaks on both platformsonAdEndsynchronously fromunregisterView); changed clickable sets now rebuild fresh views since same-root re-registration is a silent SDK no-oponPresentFailed; failed registrations clear bridge state so the next attach renderstrackoption shipped in 7.0.0) — the native overlay renders above all Unity UI and cannot be clipped by Unity viewportscom.vungle:vungle-ads:[7.7,8.0)matching the iOS pod's~> 7.7Test app
BuildScript.csfor command-line player builds; iOS Script Call Optimization set to produce hard crash logsTest plan
Device-verified on Android (Pixel) and iOS Simulator: load/attach/detach/re-attach flows, clickable-set changes via the CTA dialog, destroy-on-reload, scene exits, DualNative, and the previously crashing repros.
🤖 Generated with Claude Code