fix: handle empty and text responses with simplejson installed - #366
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests can use simplejson when it is installed. Catching the standard-library JSONDecodeError then lets decoding failures escape: successful empty responses raise instead of returning None, and plain-text error responses fail while constructing the SDK exception.
Catch requests.exceptions.JSONDecodeError in both response handlers. Extend the successful-response regression to cover empty 204, empty 200, and non-JSON 200 responses; the existing plain-text error test covers the error path.
Fixes #326.
Validation: all 62 HTTP client, Application, and Number Management tests pass both with simplejson 4.1.2 installed and without it. The empty-response and plain-text error cases failed with simplejson before their respective fixes. Black and git diff --check pass.