fix: keep JSON content type local to each request - #365
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323.
A JSON request currently writes
Content-Type: application/jsoninto the client's shared headers. Reusing that client for a form request sends URL-encoded data with the JSON content type, which can cause the reported 420 response when creating an application and then updating a number.Copy the default headers into each request and set the JSON content type on that copy. Requests can then supply the correct form content type, and query-only requests no longer inherit a JSON content type. Regression tests exercise JSON followed by form/query requests and verify authentication and default headers are preserved.
Validation: all 62 HTTP-client, Application, and Number Management tests pass on Python 3.13. Both new regressions fail before the fix. Black and
git diff --checkpass. The separate JWT package suite has two existing invalid-key fixture failures in this environment; that package is unchanged.