feat: Adding WhatsApp BSUID support to Messages - #361
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Messages WhatsApp models to support using a WhatsApp BSUID as the to recipient identifier (in addition to a phone number), and adds a unit test to cover that scenario.
Changes:
- Adds a unit test asserting a WhatsApp text message can be serialized with a BSUID in
to. - Updates the WhatsApp base model to widen the
tofield type to accept BSUID-style identifiers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
messages/tests/test_whatsapp_models.py |
Adds a new unit test for serializing a WhatsApp text message where to is a BSUID. |
messages/src/vonage_messages/models/whatsapp.py |
Updates BaseWhatsapp.to typing/docs to allow BSUID usage for WhatsApp recipients. |
Suppressed comments (1)
messages/src/vonage_messages/models/whatsapp.py:46
tois nowUnion[PhoneNumber, str], butPhoneNumberis already anAnnotated[str, Field(pattern=...)]. Adding a plainstrto the union makes validation effectively always succeed (any string matches thestrbranch), so invalid recipients that were previously rejected will now be accepted.
to: Union[PhoneNumber, str]
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
manchuck
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Messages package to add support for sending WhatsApp messages using a BSUID in the
tofield. Specifically it:tofield of a WhatsApp message objectBaseWhatsappmodel to allow the setting of the BSUID in thetofield