feat: support grouped grand totals by dimension - #5302
Open
fangsmile wants to merge 9 commits into
Open
Conversation
Allow pivot grand totals to retain lower-level dimensions. Preserve existing behavior when the option is omitted. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Isolate grouped total keys from display labels. Cover edge cases introduced by grandTotalDimensions. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Handle grouped totals across chart paths, custom edits, and indicator sorting. Support external totals and grid-tree lookup. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep nested totals and chart ranges consistent after edits. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Keep grouped grand total paths available to PivotChart data lookup. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Preserve chart ranges and header spans for grouped grand totals. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Use filtered records and ordered internal paths so grouped totals retain correct dimensions, chart ranges, custom values, and tree cell lookups. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Retain legacy value-only tree matching while using ordered internal values for grouped grand total header paths. Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grandTotalDimensionsto group grand totals by lower-level row or column dimensions while preserving the existing behavior when omittedCloses #5272
Test plan
@visactor/vtabletest suite (71 suites, 307 tests)🤖 Generated with Claude Code