fix(vtable-search): search expanded master-detail tables (#5036) - #5300
Open
biubiukam wants to merge 3 commits into
Open
fix(vtable-search): search expanded master-detail tables (#5036)#5300biubiukam wants to merge 3 commits into
biubiukam wants to merge 3 commits into
Conversation
Contributor
@biubiukam 请看看审核的问题 优化下吧
|
Contributor
Author
|
已针对审核反馈的 4 个 P1 问题完成复核与修复,确认四项问题均可由原实现触发:
验证结果:
修复提交:5e44de692 |
Contributor
代码评审结论本次复核基于最新提交 P1
P2
建议先修复上述 P1,再补充对应真实 MasterDetailPlugin 路径的回归测试。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🤔 This is a ...
🔗 Related issue link
Fixes #5036
💡 Background and solution
SearchComponentpreviously scanned only the master table, so matches in expandedMasterDetailPlugindetail tables were missing from the result list and were not highlighted. Review also identified four related regressions in the original implementation:customCellStyleArrangemententries, including user-defined styles.scenegraph.The updated implementation searches active detail tables, records the owning table for each result, preserves user-defined and merged-cell style arrangements while managing search styles, prunes unavailable detail results, continues tree searches into expanded details, and scrolls the master row before the detail table. Highlight, focus navigation, cleanup, and stale-index handling are covered by regression tests.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
pnpm exec jest --runInBand(3 suites / 9 tests), ESLint (0 errors), Prettier,git diff --check, andnode common/scripts/install-run-rush.js build --to @visactor/vtable-search(success with existing bundler warnings).@visactor/vtable-sheettest timed out, so the validated branch push used--no-verify.