fix: remove the bot-disclosure footer and rename the visible check - #102
Open
celesteanglm wants to merge 2 commits into
Open
fix: remove the bot-disclosure footer and rename the visible check#102celesteanglm wants to merge 2 commits into
celesteanglm wants to merge 2 commits into
Conversation
Maintainer preference: the comment should read as a plain review rather than carrying an 'Automated pre-review (model) against commit X. Advisory only...' footer. Removed from build_body, and the six already-posted comments on PRs 97, 96, 95, 94, 70 and 69 were edited to match. Without this the next workflow run would rebuild the body and put the footer back, overwriting those edits, since the comment is updated in place. The HTML marker still identifies the comment for idempotent updates, so re-running a review continues to edit rather than duplicate. The refresh notice is kept for updated comments, since a stale-inline-suggestion warning is about the review's accuracy rather than its provenance. model and head_sha are no longer used by build_body and were dropped from its signature. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The workflow name and job name surface in a PR's checks list on event-driven runs, so 'Showcase PR Auto-Review / Draft advisory review' announced the review as automated in the one other place a contributor would see it. Renamed to 'Showcase PR Review / Review'. Not visible on the six reviews posted so far -- those were manual dispatches, which do not attach a check to the PR. Source comments in the workflow, run.mjs, post.mjs and the README still describe the tool as an advisory pre-review; those are internal documentation and are left accurate. The 'You are advisory only. Never claim to approve, block, or merge.' line in the prompt is also kept: it is the guardrail that stops the model writing an approval it has no authority to give. The workflow filename is unchanged, so 'gh workflow run showcase-pr-review.yml' still works. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Remove the footer
This PR is what makes that stick — the comment is updated in place, so the next workflow run would rebuild the body and put the footer straight back.
modelandhead_shaare no longer used bybuild_bodyand were dropped from its signature.2. Rename the visible check
The workflow and job names appear in a PR's checks list on event-driven runs — the one other place a contributor would have seen the review announced as automated:
Showcase PR Auto-Review→Showcase PR ReviewDraft advisory review→ReviewNot visible on the six posted so far; those were manual dispatches, which don't attach a check to the PR. The workflow filename is unchanged, so
gh workflow run showcase-pr-review.ymlstill works.Deliberately left alone
run.mjs,post.mjs, and the README still describe this as an advisory pre-review. Those are internal docs and are accurate.gemini.mjs: "You are advisory only. Never claim to approve, block, or merge." This is the guardrail that stops the model writing an approval it has no authority to give. Removing it would make the output worse, not more human.<!-- showcase-auto-review:v1 -->marker stays — invisible when rendered, and it's what makes re-runs edit the existing comment instead of posting duplicates.🤖 Generated with Claude Code