Repository navigation
Keep the main HUD's edge gap when Wisp resizes it - #226
Merged
Merged
Conversation
Turning an attached gauge on in the non-native layouts widened the HUD into the screen edge once restores stopped keeping a margin. The window now keeps the gap it had, up to the default margin. The 2.7.6 notes list the gauges that can sit against any edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #224, found in review before the 2.7.6 tag.
What changes
RestorePosition, a HUD at its default top-right position ended up touching the screen edge.OverlayPlacementGeometry.KeepEdgeGapsnow keeps the gap the window had to an edge it would cross, up to the default margin: a default placement keeps its 24 DIP, and a HUD the player put against the edge stays against it. The native layout is unchanged.Checked
OverlayPlacementGeometryTests: default margin kept, flush stays flush, a smaller gap is kept, a far element that grows past the edge gets the default margin, an element that still fits does not move; bottom edge; unknown position passes through.Not checked