vtsingle/vlsingle: add removePvcAfterDelete field

[vrutkovs]

Similar to VMCluster add support for removePvcAfterDelete so that we could conditionally remove PVCs

[cubic-dev-ai]

3 issues found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:26">
P3: This changelog entry claims the PR adds `minVersion` in addition to `removePvcAfterDelete`, but the PR only adds `removePvcAfterDelete`. `minVersion` is not added for vtsingle/vlsingle here; the existing `MinVersion` is the already-documented syslog tlsConfig field and is unrelated to PVC cleanup. Drop `minVersion` from the entry so the changelog describes the actual change.</violation>

<violation number="2" location="docs/CHANGELOG.md:26">
P3: The changelog entry for this PR incorrectly lists `minVersion` alongside `removePvcAfterDelete`. This change only adds `removePvcAfterDelete` to `VLSingle`/`VTSingle`; `minVersion` belongs to the unrelated syslog `tlsConfig` feature in the line above. The mention is a copy-paste error that misleads readers about what this release adds.</violation>

<violation number="3" location="docs/CHANGELOG.md:26">
P1: Custom agent: **Technical Writer Review Agent**

The changelog entry incorrectly claims that `minVersion` was added to support PVC cleanup, likely due to a copy-paste error from the line above. `minVersion` is a TLS field and is unrelated to PVCs. Remove the mention of `minVersion` to accurately reflect the PR's changes.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic</sub>

[cubic-dev-ai]

P1: Custom agent: Technical Writer Review Agent

The changelog entry incorrectly claims that minVersion was added to support PVC cleanup, likely due to a copy-paste error from the line above. minVersion is a TLS field and is unrelated to PVCs. Remove the mention of minVersion to accurately reflect the PR's changes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 26:

<comment>The changelog entry incorrectly claims that `minVersion` was added to support PVC cleanup, likely due to a copy-paste error from the line above. `minVersion` is a TLS field and is unrelated to PVCs. Remove the mention of `minVersion` to accurately reflect the PR's changes.</comment>

<file context>
@@ -23,6 +23,7 @@ aliases:
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/): add `VTAgent` CRD for [vtagent](https://docs.victoriametrics.com/victoriatraces/vtagent/), which replicates ingested OTLP trace spans across one or more VictoriaTraces instances using a persistent queue on disk. See [#2510](https://github.com/VictoriaMetrics/operator/pull/2510).
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/), [vtcluster](https://docs.victoriametrics.com/operator/resources/vtcluster/): add `grpcSpec` field (`spec.insert.grpcSpec` for `VTCluster`) to accept OTLP trace spans over gRPC in addition to HTTP, with optional TLS via `tlsConfig`.
 * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/), [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vlcluster](https://docs.victoriametrics.com/operator/resources/vlcluster/): add `cipherSuites` and `minVersion` fields to syslog listener `tlsConfig`.
+* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
 
 * BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/), [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): default `spec.shardCount` to `0` at the CRD schema level, fixing `VerticalPodAutoscaler`'s `/scale` subresource lookups failing with `the spec replicas field ".spec.shardCount" does not exist` whenever sharding wasn't configured (the common case). See [#2473](https://github.com/VictoriaMetrics/operator/issues/2473).
</file context>

Suggested change

	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` field to support PVC cleanup after deletion.

[cubic-dev-ai]

P3: This changelog entry claims the PR adds minVersion in addition to removePvcAfterDelete, but the PR only adds removePvcAfterDelete. minVersion is not added for vtsingle/vlsingle here; the existing MinVersion is the already-documented syslog tlsConfig field and is unrelated to PVC cleanup. Drop minVersion from the entry so the changelog describes the actual change.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 26:

<comment>This changelog entry claims the PR adds `minVersion` in addition to `removePvcAfterDelete`, but the PR only adds `removePvcAfterDelete`. `minVersion` is not added for vtsingle/vlsingle here; the existing `MinVersion` is the already-documented syslog tlsConfig field and is unrelated to PVC cleanup. Drop `minVersion` from the entry so the changelog describes the actual change.</comment>

<file context>
@@ -23,6 +23,7 @@ aliases:
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/): add `VTAgent` CRD for [vtagent](https://docs.victoriametrics.com/victoriatraces/vtagent/), which replicates ingested OTLP trace spans across one or more VictoriaTraces instances using a persistent queue on disk. See [#2510](https://github.com/VictoriaMetrics/operator/pull/2510).
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/), [vtcluster](https://docs.victoriametrics.com/operator/resources/vtcluster/): add `grpcSpec` field (`spec.insert.grpcSpec` for `VTCluster`) to accept OTLP trace spans over gRPC in addition to HTTP, with optional TLS via `tlsConfig`.
 * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/), [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vlcluster](https://docs.victoriametrics.com/operator/resources/vlcluster/): add `cipherSuites` and `minVersion` fields to syslog listener `tlsConfig`.
+* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
 
 * BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/), [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): default `spec.shardCount` to `0` at the CRD schema level, fixing `VerticalPodAutoscaler`'s `/scale` subresource lookups failing with `the spec replicas field ".spec.shardCount" does not exist` whenever sharding wasn't configured (the common case). See [#2473](https://github.com/VictoriaMetrics/operator/issues/2473).
</file context>

Suggested change

	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` field to support PVC cleanup after deletion.

[cubic-dev-ai]

P3: The changelog entry for this PR incorrectly lists minVersion alongside removePvcAfterDelete. This change only adds removePvcAfterDelete to VLSingle/VTSingle; minVersion belongs to the unrelated syslog tlsConfig feature in the line above. The mention is a copy-paste error that misleads readers about what this release adds.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 26:

<comment>The changelog entry for this PR incorrectly lists `minVersion` alongside `removePvcAfterDelete`. This change only adds `removePvcAfterDelete` to `VLSingle`/`VTSingle`; `minVersion` belongs to the unrelated syslog `tlsConfig` feature in the line above. The mention is a copy-paste error that misleads readers about what this release adds.</comment>

<file context>
@@ -23,6 +23,7 @@ aliases:
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/): add `VTAgent` CRD for [vtagent](https://docs.victoriametrics.com/victoriatraces/vtagent/), which replicates ingested OTLP trace spans across one or more VictoriaTraces instances using a persistent queue on disk. See [#2510](https://github.com/VictoriaMetrics/operator/pull/2510).
 * FEATURE: [vtagent](https://docs.victoriametrics.com/operator/resources/vtagent/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/), [vtcluster](https://docs.victoriametrics.com/operator/resources/vtcluster/): add `grpcSpec` field (`spec.insert.grpcSpec` for `VTCluster`) to accept OTLP trace spans over gRPC in addition to HTTP, with optional TLS via `tlsConfig`.
 * FEATURE: [vlagent](https://docs.victoriametrics.com/operator/resources/vlagent/), [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vlcluster](https://docs.victoriametrics.com/operator/resources/vlcluster/): add `cipherSuites` and `minVersion` fields to syslog listener `tlsConfig`.
+* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
 
 * BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/), [vmanomaly](https://docs.victoriametrics.com/operator/resources/vmanomaly/): default `spec.shardCount` to `0` at the CRD schema level, fixing `VerticalPodAutoscaler`'s `/scale` subresource lookups failing with `the spec replicas field ".spec.shardCount" does not exist` whenever sharding wasn't configured (the common case). See [#2473](https://github.com/VictoriaMetrics/operator/issues/2473).
</file context>

Suggested change

	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` and `minVersion` fields to support PVC cleanup after deletion.
	* FEATURE: [vlsingle](https://docs.victoriametrics.com/operator/resources/vlsingle/), [vtsingle](https://docs.victoriametrics.com/operator/resources/vtsingle/): add `removePvcAfterDelete` field to support PVC cleanup after deletion.

[AndrewChubatiuk]

since this option was dropped while VLSingle was added as a replacement for VLogs thought it's deprecated

[vrutkovs]

I think its useful to have, in any case, it would useful to have this option across V*Single