operator: set status for child objects if no parent objects exist - #2539
Open
AndrewChubatiuk wants to merge 1 commit into
Open
operator: set status for child objects if no parent objects exist#2539AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
AndrewChubatiuk
force-pushed
the
set-default-status-for-child-resources
branch
from
August 24, 2026 13:13
db07321 to
be824e7
Compare
vrutkovs
requested changes
Aug 26, 2026
| }) | ||
| } | ||
| err = g.Wait() | ||
| if err = g.Wait(); err != nil { |
Collaborator
There was a problem hiding this comment.
This would return just the parent status on err, ignoring child status, imo
err = g.Wait()
if syncErr := reconcile.SyncAggregatedChildStatus(ctx, r.Client, &instance); syncErr != nil && err == nil {
err = syncErr
}
return
would include both parent and child errors correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change should address comment #1181 (comment)