Repository navigation
fix(tools): restore extracted resource pack definitions - #469
Closed
AlexProgrammerDE wants to merge 1 commit into
Closed
AlexProgrammerDE wants to merge 1 commit into
AlexProgrammerDE wants to merge 1 commit into
Conversation
The Gradle tooling refactor in ViaVersionAddons#413 removed the __brarchive folder support introduced by ViaVersionAddons#415. Normal brax output still uses that layout, so pack generation succeeds while omitting biome, fog and render-controller data. Merge direct and extracted definition folders into the generated pack. Preserve direct files on duplicate paths, close directory streams and propagate copy failures instead of silently producing incomplete output. Exercise the actual ZIP writer with extracted, mixed and direct layouts. Restore schema guidance for compiled MCB resources in the update process. Validate on the update/r26u6 branch with a complete build and three tests. Removing the extracted-folder source makes two regressions fail. Running the generator against the verified 1.26.60.5 GDK extraction restores 344 biome, 249 fog and 214 render-controller files across the bundled packs. The generated vanilla skin archive retains its existing file contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pack generator must read the normal output of
braxwithout a manual directory merge.The extractor places definitions under each pack's
__brarchivedirectory.The generator currently skips those directories and reports success with incomplete archives.
This restores the folder handling introduced in #415 and removed by #413.
Direct definitions retain priority when both layouts contain the same file.
Copy failures stop generation, and directory streams close after each copy.
The update instructions also restore schema guidance for compiled MCB resources.
This PR targets
update/r26u6and contains the generator fix, tests, and extraction instructions.The regenerated archives remain in PR #468.
The pre-existing font extraction limitation remains outside this restoration.
Validation on the target branch:
./gradlew --no-configuration-cache buildpasses, including all Checkstyle tasks and three generator tests.