Repository navigation
fix(protocol): complete 26.60 attack swing framing and checks - #467
Merged
Exterminate5573 merged 2 commits intoOct 28, 2026
Merged
Exterminate5573 merged 2 commits into
Exterminate5573 merged 2 commits into
Conversation
Protocol 2225 adds a trailing hand byte to Animate. The ordinary punch writer already supplies it, but the explicit attack helper still emits the old layout and BDS rejects that packet. Match the main-hand field used by the updated punch path.
The new readers introduce nine checkstyle errors: unused decoded fields, non-final locals, and a misindented record closing parenthesis. Consume intentionally unused fields without assigning locals and retain the existing packet behavior.
AlexProgrammerDE
marked this pull request as ready for review
October 28, 2026 08:17
AlexProgrammerDE
marked this pull request as draft
October 28, 2026 08:17
Exterminate5573
marked this pull request as ready for review
October 28, 2026 08:22
Exterminate5573
merged commit Oct 28, 2026
d4371a2
into
ViaVersionAddons:update/r26u6
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #466, targeting
update/r26u6.Explicit entity attacks call
ClientPlayerEntity.sendSwingPacketToServer(), which still writes the old Animate layout. Append the protocol-2225 main-hand byte, matching the updated ordinary punch path. Without that byte, BDS rejects the attack swing packet.Also fix the nine checkstyle errors introduced by the version update: non-final reader locals, unused decoded fields, and the release record's indentation. Intentionally unused fields remain consumed in the same order.
Validation:
./gradlew buildpasses, including main and tool checkstyle.