Skip to content

1.9→1.8: melee hits play arrow sounds since 4.2.0 #726

Description

@lllupin

/viaversion dump Output

https://dump.viaversion.com/9c10c5249efa46bec1beea096cbe21350b03871ef636ab99fcab8833f973bad5

Console Error

No response

Bug Description

Since ViaRewind 4.2.0 (Mappings#128 / #689), 1.8 clients hear arrow sounds on every melee hit:

  • Hitting a player/mob that takes no damage (e.g. creative) plays the arrow-landing sound (random.bowhit).
  • Hitting normally plays the arrow-hit "ding" (random.successful_hit) on top of the regular hurt sound.

This comes from the new mappings in mapping-1.9to1.8.json:

"entity.player.attack.crit": "random.successful_hit",
"entity.player.attack.knockback": "random.successful_hit",
"entity.player.attack.nodamage": "random.bowhit",
"entity.player.attack.strong": "random.successful_hit",
"entity.player.attack.sweep": "random.successful_hit",
"entity.player.attack.weak": "random.successful_hit",

Doesn't happen with 1.9+ clients, or with ViaRewind before 4.2.0.

Why this is a problem

  • It plays on every single hit. 1.8 PvP relies on click spamming, so players hear an arrow "ding" several times per second during any fight. It's constant noise on top of the normal hurt sound. It also plays in creative mode, when the player takes no damage at all.
  • It's misleading. random.successful_hit is the 1.8 feedback sound for landing an arrow on a player. Now melee hits sound the same, so players can no longer tell when their bow shots actually hit.
  • random.bowhit sounds like incoming arrows. Hitting a player in creative, an invulnerable player, or anything that takes no damage plays the arrow-landing sound, which makes players think someone is shooting at them.

Steps to Reproduce

1.12.2 server with ViaVersion 5.12.0, ViaBackwards 5.12.0, ViaRewind 4.2.0.
Join with a 1.8 client and hit a player in creative → arrow landing sound.
Hit a player in survival → arrow "ding" + hurt sound.

Expected Behavior

Melee hits should sound exactly like vanilla 1.8: only the victim's hurt sound (game.player.hurt) when damage is dealt, and no sound at all when the hit deals no damage. The entity.player.attack.* sounds don't exist in 1.8 and should be dropped (""), as they were before 4.2.0.

"entity.player.attack.crit": "",
"entity.player.attack.knockback": "",
"entity.player.attack.nodamage": "",
"entity.player.attack.strong": "",
"entity.player.attack.sweep": "",
"entity.player.attack.weak": "",

Additional Server Info

No response

Checklist

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions