LOG-9386: fix(disk buffer): treat decode errors as bad reads during initialization seek

[vparfonov]

Apply upstream PR vectordotdev#25691 with adjusted test naming.

Add ReaderError::Decode to is_bad_read() so the reader skips the corrupted data file during initialization instead of failing with CrashLoop.

JIRA: https://redhat.atlassian.net/browse/LOG-9386

/assign @jcantrill

[openshift-ci-robot]

@vparfonov: This pull request references LOG-9386 which is a valid jira issue.

Details

In response to this:

Apply upstream PR vectordotdev#25691 with adjusted test naming.

Add ReaderError::Decode to is_bad_read() so the reader skips the corrupted data file during initialization instead of failing with CrashLoop.

JIRA: https://redhat.atlassian.net/browse/LOG-9386

/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a46fe331-1a25-4b3a-8b88-97eeb9e2347c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[jcantrill]

@vparfonov most of this PR is test code where my understanding of the logic is weak. Does adding this one error type the only thing that modifies the behavior from "crash" to "skip"?

[vparfonov]

/hold

[vparfonov]

/hold cancel

[vparfonov]

@vparfonov most of this PR is test code where my understanding of the logic is weak. Does adding this one error type the only thing that modifies the behavior from "crash" to "skip"?

Yes, correct

[jcantrill]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment