fix: propagate CDOpt runner failures safely - #9
Open
christiek673-mAth wants to merge 1 commit into
Open
Conversation
Author
|
Hi maintainers, could you please review this PR? It hardens the three CDOpt runner generators against unsafe output paths, validates parameters, and propagates execution/solver/verification failures through the generated runner exit status. Local Python 3.11 validation passed: 32 tests passed, 5 dependency-gated numerical tests skipped because optional OSQP/NumPy dependencies were unavailable locally, and git diff --check passed. The fork PR workflow currently shows action_required with no jobs started; could a maintainer please approve and run the Validate skills workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3.11 -m unittest discover -s tests -qgit diff --checkpassed.The repository's existing test workflow installs the OSQP test dependency; the skipped tests are dependency-gated numerical tests, not failures.