Skip to content

fix: propagate CDOpt runner failures safely - #9

Open
christiek673-mAth wants to merge 1 commit into
VeryMath:mainfrom
christiek673-mAth:security/cdopt-runner-failure-propagation
Open

fix: propagate CDOpt runner failures safely#9
christiek673-mAth wants to merge 1 commit into
VeryMath:mainfrom
christiek673-mAth:security/cdopt-runner-failure-propagation

Conversation

@christiek673-mAth

Copy link
Copy Markdown

Summary

  • Harden the three CDOpt runner generators against symlinked or invalid output paths.
  • Validate generated runner parameters before execution.
  • Propagate training/solver/verification failures through the generated runner exit status.
  • Add explicit execution, solver, verification, and completion fields to generated summaries.
  • Add regression tests for generated runner compilation, failure exit propagation, and symlink protection.

Validation

  • python3.11 -m unittest discover -s tests -q
  • Result: 32 tests passed, 5 skipped because optional numerical dependencies are unavailable locally.
  • git diff --check passed.

The repository's existing test workflow installs the OSQP test dependency; the skipped tests are dependency-gated numerical tests, not failures.

@christiek673-mAth

Copy link
Copy Markdown
Author

Hi maintainers, could you please review this PR? It hardens the three CDOpt runner generators against unsafe output paths, validates parameters, and propagates execution/solver/verification failures through the generated runner exit status. Local Python 3.11 validation passed: 32 tests passed, 5 dependency-gated numerical tests skipped because optional OSQP/NumPy dependencies were unavailable locally, and git diff --check passed. The fork PR workflow currently shows action_required with no jobs started; could a maintainer please approve and run the Validate skills workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant