Skip to content

🔨 Support new vdTelemetry mod#2

Open
Grisu118 wants to merge 4 commits into
mainfrom
vdtelemetry
Open

🔨 Support new vdTelemetry mod#2
Grisu118 wants to merge 4 commits into
mainfrom
vdtelemetry

Conversation

@Grisu118

@Grisu118 Grisu118 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added a public scripting API for lowering, folding, and activating front, rear, attached-implement, and vehicle mechanisms.
    • Added support for cascading actions across attached implements.
    • Updated telemetry integration for improved vehicle entry and exit handling.
  • Documentation

    • Added scripting API examples and development/packaging guidance.
    • Updated release information and compatibility details.
  • Chores

    • Updated the release version to 1.1.0.0 and refreshed licensing text.

Grisu118 and others added 4 commits July 3, 2026 22:21
foldObject derived its direction from getToggledFoldDirection() in both
branches, so vdAIFoldVehicle(true) and vdAIFoldVehicle(false) both toggled
the fold; the boolean only picked setFoldState's moveToMiddle argument. This
made the public fold API unusable as an absolute command from vdTelemetry,
where correctness only held by coincidence of a matching predicate on the
app side.

Derive the fold direction from the requested state instead: forceState now
means "should end up folded" (true folds, false unfolds, nil toggles). The
resting/in-flight state is read from foldMoveDirection while animating and
getIsUnfolded() at rest, and a command already matching that state returns
early as a no-op while still cascading to child implements.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The release updates AdditionalInputs to version 1.1.0.0, rewires telemetry integration, adds public implement-control APIs, replaces action-event handling with shared control helpers, and documents the API and packaging workflow.

Changes

AdditionalInputs API and release update

Layer / File(s) Summary
Version and release metadata
AI.lua, fstools.toml, modDesc.xml
Version constants, packaging metadata, module version, changelog entries, and module header information are updated for 1.1.0.0.
Public API registration and telemetry wiring
AISpec.lua
New lower, fold, activate, and callback APIs are registered, while vehicle entry and exit handling uses g_vdTelemetry.
Shared implement control pipeline
AISpec.lua
Shared helpers control attached implements by position, support vehicle-specific mechanisms, and replace the removed vdAIActionEvent flow.
Repository guidance and API documentation
CLAUDE.md, Readme.md, LICENSE
Repository instructions, scripting API examples, packaging guidance, and license wording are updated.

Estimated code review effort: 4 (Complex) | ~45 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the primary change: the mod now supports vdTelemetry and rewires telemetry integration accordingly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vdtelemetry

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
AISpec.lua (1)

317-343: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Address the leftover TODO.

--TODO improve this if is left in the condition guarding lowering. Want me to help work out the exact condition intended here (or open a tracking issue)?

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@AISpec.lua` around lines 317 - 343, Remove the leftover “TODO improve this
if” comment in lowerObject and clean up the guarding condition without changing
its behavior, preserving the existing allowsLowering, pickup, and
getIsFoldMiddleAllowed checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@AISpec.lua`:
- Around line 317-343: Remove the leftover “TODO improve this if” comment in
lowerObject and clean up the guarding condition without changing its behavior,
preserving the existing allowsLowering, pickup, and getIsFoldMiddleAllowed
checks.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 052658ca-e346-410d-897c-4cd959957ceb

📥 Commits

Reviewing files that changed from the base of the PR and between d5ae791 and 658b099.

📒 Files selected for processing (7)
  • AI.lua
  • AISpec.lua
  • CLAUDE.md
  • LICENSE
  • Readme.md
  • fstools.toml
  • modDesc.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant