🔨 Support new vdTelemetry mod#2
Conversation
foldObject derived its direction from getToggledFoldDirection() in both branches, so vdAIFoldVehicle(true) and vdAIFoldVehicle(false) both toggled the fold; the boolean only picked setFoldState's moveToMiddle argument. This made the public fold API unusable as an absolute command from vdTelemetry, where correctness only held by coincidence of a matching predicate on the app side. Derive the fold direction from the requested state instead: forceState now means "should end up folded" (true folds, false unfolds, nil toggles). The resting/in-flight state is read from foldMoveDirection while animating and getIsUnfolded() at rest, and a command already matching that state returns early as a no-op while still cascading to child implements. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe release updates AdditionalInputs to version 1.1.0.0, rewires telemetry integration, adds public implement-control APIs, replaces action-event handling with shared control helpers, and documents the API and packaging workflow. ChangesAdditionalInputs API and release update
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
AISpec.lua (1)
317-343: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAddress the leftover TODO.
--TODO improve this ifis left in the condition guarding lowering. Want me to help work out the exact condition intended here (or open a tracking issue)?🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@AISpec.lua` around lines 317 - 343, Remove the leftover “TODO improve this if” comment in lowerObject and clean up the guarding condition without changing its behavior, preserving the existing allowsLowering, pickup, and getIsFoldMiddleAllowed checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@AISpec.lua`:
- Around line 317-343: Remove the leftover “TODO improve this if” comment in
lowerObject and clean up the guarding condition without changing its behavior,
preserving the existing allowsLowering, pickup, and getIsFoldMiddleAllowed
checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 052658ca-e346-410d-897c-4cd959957ceb
📒 Files selected for processing (7)
AI.luaAISpec.luaCLAUDE.mdLICENSEReadme.mdfstools.tomlmodDesc.xml
Summary by CodeRabbit
New Features
Documentation
Chores