Fragment no longer opens on a blank line - #597
Merged
Merged
Conversation
A fragment is parsed against a context element, and PrettyMarkupFormatter breaks the line before every node that sits inside an element. That context element is never itself written, so the first node took the break with nothing in front of it and the markup opened on the second line. A document has no such context, and a fragment leading with text is not broken before either, so the ones affected were those leading with an element or a comment. The break is now dropped from the front of the formatted output. The seven fragment snapshots recorded the blank line rather than failing on it. The registered html comparer diffs the two DOMs, where a blank line before the first node is whitespace between nodes and no difference at all, so nothing here could see it — only a consumer comparing the snapshot as text. The new test compares as text for that reason, and is the only one in the fixture that fails when the trim is taken back out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fragment is parsed against a context element, and PrettyMarkupFormatter breaks the line before every node that sits inside an element. That context element is never itself written, so the first node took the break with nothing in front of it and the markup opened on the second line. A document has no such context, and a fragment leading with text is not broken before either, so the ones affected were those leading with an element or a comment. The break is now dropped from the front of the formatted output.
The seven fragment snapshots recorded the blank line rather than failing on it. The registered html comparer diffs the two DOMs, where a blank line before the first node is whitespace between nodes and no difference at all, so nothing here could see it — only a consumer comparing the snapshot as text. The new test compares as text for that reason, and is the only one in the fixture that fails when the trim is taken back out.