fix: use useFormState to read RHF state#5677
Conversation
🦋 Changeset detectedLatest commit: a675895 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis PR changes form state reads to use React Hook Form subscriptions. The main changes are:
Confidence Score: 5/5The changed flow looks mergeable after restoring the revoke button label.
apps/evm/src/components/SpendingLimit/index.tsx Important Files Changed
Reviews (1): Last reviewed commit: "fix: use useFormState to read RHF state" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| <TextButton onClick={handleRevoke} className="text-red ml-2 h-auto p-0"> | ||
| <InfoIcon | ||
| iconName="bin" | ||
| iconClassName="text-red h-5 w-5 transition-opacity hover:opacity-50 active:opacity-50" | ||
| tooltip={t('spendingLimit.revokeButtonTooltip')} | ||
| className="inline-flex" | ||
| <Icon | ||
| name="bin" | ||
| className="text-red h-5 w-5 transition-opacity hover:opacity-50 active:opacity-50" | ||
| /> |
There was a problem hiding this comment.
When the spending-limit row renders the revoke action, the changed button now contains only a bare Icon. The previous InfoIcon supplied the translated “Revoke spending limit” tooltip on hover, focus, and mobile tap, so this destructive icon button now has no visible or accessible explanation before users activate it.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
That's expected, we don't want a tooltip here.
therealemjy
force-pushed
the
fix/vault-forms
branch
from
70a9f1a to
a675895
Compare
Coverage Report for ./apps/evm
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
2 participants
Changes