Fix a leak in BinaryReader::ReadVector - #8453
Open
saagarjha wants to merge 1 commit into
Open
Conversation
The new behavior requires that T is value initializable but generally you have no business calling this function if that is not the case, so this should be fine.
Member
|
Contributor
Author
|
reserve doesn't change the vector's size which means it mostly just changes the backing buffer without making it available to us to write into. I don't think there is an easy way to uninitialized-fill a vector unfortunately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new behavior requires that T is value initializable but generally you have no business calling this function if that is not the case, so this should be fine.