fix #426: Flash reads AES PDFs and guards lazy PyPDF2 failures - #435
Open
xinyao-li wants to merge 1 commit into
Open
fix #426: Flash reads AES PDFs and guards lazy PyPDF2 failures#435xinyao-li wants to merge 1 commit into
xinyao-li wants to merge 1 commit into
Conversation
Add PyCryptodome as PyPDF2's AES backend and force page-tree resolution inside the existing guarded open so an unavailable secondary parser falls back to PDFium instead of crashing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PyCryptodome as PyPDF2's AES backend and force page-tree resolution inside the existing guarded open so an unavailable secondary parser falls back to PDFium instead of crashing.
Summary
Fixes #426.
Root cause
PyPDF2 parses the page tree lazily.
PdfReader()succeeded inside theexisting try/except, but
len(reader.pages)later raisedDependencyErroroutside that guard while decrypting an AES-encrypted object stream.
Resolving and caching the page count in
_PdfDoc.__init__keeps that lazyfailure inside the existing guarded open used by both sequential and
parallel parsing.
Test plan
parallel parsing
386 passed, 53 skipped