feat: add case preservation support via custom :s flag P (#3978) - #10040
Open
ronaldocheruiyot wants to merge 1 commit into
Open
feat: add case preservation support via custom :s flag P (#3978)#10040ronaldocheruiyot wants to merge 1 commit into
ronaldocheruiyot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for preserving case during a substitution command (
:s), matching the native behavior found in VSCode's built-in Find and Replace functionality.Because standard Vim uses the lowercase
pflag for printing the last matched line, this introduces a custom uppercasePflag to handle case preservation (e.g., running:%s/foo/bar/Pwill dynamically transformFOO foo FoointoBAR bar Bar).It intercepts the substitution loop via a custom utility function that checks the original matched string's text layout (UPPERCASE, lowercase, or Title Case) and applies the identical format to the incoming replacement string before writing it to the document transformer.
Which issue(s) this PR fixes
Fixes #3978
Special notes for your reviewer:
test/cmd_line/substitute.test.tsto validate UPPER, lower, and Title Case execution scenarios simultaneously.yarn build-dev.