add flushed_http_code tag - #1678
Open
Shamzik wants to merge 7 commits into
Open
Conversation
Shamzik
added
runtime
Shamzik
force-pushed
the
kshamazov/flushed_http_code
branch
from
August 26, 2026 11:49
6a2c5b8 to
ffbb687
Compare
Shamzik
force-pushed
the
kshamazov/flushed_http_code
branch
from
August 26, 2026 12:36
ffbb687 to
de1e7c3
Compare
apolyakov
reviewed
Sep 3, 2026
| php_query_data_t data; | ||
|
|
||
| bool paused; | ||
| bool flushed_http_connection; |
Contributor
There was a problem hiding this comment.
We already have a global containing the HTTP code. Can we use it instead?
| if (process_type == ProcessType::http_worker) { | ||
| client.metric("kphp_by_host_http_connection_process_time", true).tag(status).write_value(http_connection_process_time); | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Warray-bounds" |
Contributor
There was a problem hiding this comment.
Let's try finding a way to not use this hack
GCC 8 inlines copies of pack_string into callers and merges them (cross-jumping), after which it loses the relation between `len` and the source object and emits false positive -Warray-bounds for small string literals. Mark pack_string noinline for GCC 8 only. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds flushed_http_code tag to http metrics