Skip to content

Fix slow random walk in Random8 Perlin/FBM styles #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quasor wants to merge 1 commit into from
Closed

Fix slow random walk in Random8 Perlin/FBM styles #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/random8_core/random_cores/R_Perlin_Styles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,11 @@ namespace R8{
}

uint16_t generate() override {
positionX = (positionX + 1) % SIXTEEN_BIT_MAX;
float pos = (float)positionX / (float)SIXTEEN_BIT_MAX;
// positionX advances one phase step per trigger. The walk speed is set by the
// phase resolution (the hardware 12-bit range), not the 16-bit output range:
// normalizing over SIXTEEN_BIT_MAX would shrink each step ~16x and stall the walk.
positionX = (positionX + 1) % TWELVE_BIT_MAX;
float pos = (float)positionX / (float)TWELVE_BIT_MAX;
return (uint16_t)(perlin1d(pos, 920.666, 2) * SIXTEEN_BIT_MAX);
}

Expand Down Expand Up @@ -60,8 +63,11 @@ namespace R8{
}

uint16_t generate() override {
positionX = (positionX + 1) % SIXTEEN_BIT_MAX;
float pos = (float)positionX / (float)SIXTEEN_BIT_MAX;
// positionX advances one phase step per trigger. The walk speed is set by the
// phase resolution (the hardware 12-bit range), not the 16-bit output range:
// normalizing over SIXTEEN_BIT_MAX would shrink each step ~16x and stall the walk.
positionX = (positionX + 1) % TWELVE_BIT_MAX;
float pos = (float)positionX / (float)TWELVE_BIT_MAX;
return (uint16_t)(perlin1d(pos, 720.1459, 10) * SIXTEEN_BIT_MAX);
}

Expand Down