Send the org selector header from the artifact shell host - #1501
Merged
Conversation
The console artifact page's HTTP host sent only content-type and authorization, so every artifact tool call on cloud failed with no_organization once org-scoped session reads began failing closed. Head all three of its requests (executions, resume, preview upload) the same way the typed API client does, resolving the scope per request.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | ba91e0f | Commit Preview URL Branch Preview URL |
Jul 29 2026, 09:54 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
executor-cloud | ba91e0f | Jul 29 2026, 09:52 PM |
RhysSullivan
marked this pull request as ready for review
July 29, 2026 21:52
Contributor
Cloudflare previewTorn down — the PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prod fix: every artifact tool call on cloud fails with
no_organization— the console artifact page's HTTP shell host sent only content-type + authorization, and #1488 made org-scoped session reads fail closed without the org selector header.The host now heads all three of its requests (
POST /executions,POST /executions/:id/resume,PUT /artifacts/:id/preview) the same way the typed API client does, viagetExecutorOrganizationHeaders(), resolved per request so the memoized host can't outlive the org it named. Hosts without org scoping produce no slug and send no header, unchanged.Why dev/CI missed it: the artifacts branch was cut before #1488 merged, so header-less requests still fell back to the session org everywhere the feature was exercised; the collision only existed after both landed on main.
Unit tests cover all three request types with and without an active slug.