Keep the pasted credential across the wizard's mid-flow refetch - #1499
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 26c8805 | Commit Preview URL Branch Preview URL |
Jul 29 2026, 08:42 PM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 26c8805 | Jul 29 2026, 08:42 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
July 29, 2026 21:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's E2E has been red since #1483 (connect-handoff, connect-handoff-session, connect-link-multi-org). Two causes, both in the add-connection wizard:
allMethods, whose identity changes whenever the integration refetches. Fix GraphQL introspection health diagnostics #1483 made Continue probe the key and save the health check, which triggers exactly such a refetch mid-flow — re-running the reset and callingsetValues({}), wiping the credential the user just pasted. Step 2's Add connection button then stays disabled forever. The prefill now applies once per handoff key.connect-link-multi-orgsaves a credential unprobed by design) reads as degraded/unknown, which stranded the user on step 1. Only a definitive credential rejection (expired, the 401/403 wall) blocks now; inconclusive probes advance.Verified:
connect-handoff+connect-handoff-session(selfhost),connect-handoff-session+connect-link-multi-org(cloud), andgraphql-introspection-health(selfhost, the scenario #1483 added — its 401 path still blocks) all pass locally. Unit tests, lint, typecheck, format green.