Re-enable test and configuration#1797
Open
K8Sewell wants to merge 8 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
requested changes
Jul 3, 2026
demiankatz
left a comment
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @K8Sewell, this looks great! See below for one incredibly minor nitpick.
Beyond that, one other question: it looks to me like this PR is actually fixing a buggy implementation. Should we rename it to reflect that fact (e.g. "Fix thumbnail cache invalidation; re-enable tests")?
| }); | ||
| }); | ||
| }); | ||
| }); No newline at end of file |
Contributor
There was a problem hiding this comment.
Doesn't look like anything has changed here except the removal of an end of file line break -- might as well put it back to avoid unnecessary diffs.
Suggested change
| }); | |
| }); | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Related Issue
#1750