Bump @openseadragon-imaging/openseadragon-viewerinputhook from 2.2.1 to 3.0.1#1771
Conversation
Bumps [@openseadragon-imaging/openseadragon-viewerinputhook](https://github.com/openseadragon-imaging/openseadragon-viewerinputhook) from 2.2.1 to 3.0.1. - [Changelog](https://github.com/openseadragon-imaging/openseadragon-viewerinputhook/blob/master/CHANGELOG.md) - [Commits](openseadragon-imaging/openseadragon-viewerinputhook@v2.2.1...v3.0.1) --- updated-dependencies: - dependency-name: "@openseadragon-imaging/openseadragon-viewerinputhook" dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
left a comment
There was a problem hiding this comment.
Based on the changelog, I'm reasonably confident that there aren't relevant breaking changes here, and I don't see anything obviously wrong (plus tests are passing). However, it looks to me like the viewer input hook is only used in one very specific place, and I'm not sure how to test that code, so I'm not going to merge this right away. If anyone else can weigh in, I'd appreciate it!
@demiankatz I based my manual testing on my understanding of the "one very specific place" you mentioned. It appears that |
|
@LanieOkorodudu, the one specific place I mentioned only seems to do something if the |
Bumps @openseadragon-imaging/openseadragon-viewerinputhook from 2.2.1 to 3.0.1.
Changelog
Sourced from @openseadragon-imaging/openseadragon-viewerinputhook's changelog.
Commits
feae493Add TypeScript declaration file map578e530Update package.jsondd4e173Update README.md9dece33Merge pull request #42 from openseadragon-imaging/ms-3.0.04784dfdMerge branch 'master' into ms-3.0.07b48ad4TypeScript rewrite, v3.0.048aaf58Merge pull request #41 from openseadragon-imaging/dependabot/npm_and_yarn/fas...d0aef2eBump fast-uri from 3.1.0 to 3.1.2af95bbfMerge pull request #40 from openseadragon-imaging/dependabot/npm_and_yarn/pos...f6e7054Bump postcss from 8.4.31 to 8.5.10Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)