Skip to content

Bump @openseadragon-imaging/openseadragon-viewerinputhook from 2.2.1 to 3.0.1#1771

Open
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/dev/openseadragon-imaging/openseadragon-viewerinputhook-3.0.1
Open

Bump @openseadragon-imaging/openseadragon-viewerinputhook from 2.2.1 to 3.0.1#1771
dependabot[bot] wants to merge 1 commit into
devfrom
dependabot/npm_and_yarn/dev/openseadragon-imaging/openseadragon-viewerinputhook-3.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 1, 2026

Copy link
Copy Markdown
Contributor

Bumps @openseadragon-imaging/openseadragon-viewerinputhook from 2.2.1 to 3.0.1.

Changelog

Sourced from @​openseadragon-imaging/openseadragon-viewerinputhook's changelog.

3.0.0:

  • Now using Vite for development and build processes
  • Rewritten in TypeScript with full types for better DX
  • Returning false in MouseTracker event handlers doesn't prevent bubbling - removed that feature
  • Two distribution bundles, UMD module and ES module
Commits
  • feae493 Add TypeScript declaration file map
  • 578e530 Update package.json
  • dd4e173 Update README.md
  • 9dece33 Merge pull request #42 from openseadragon-imaging/ms-3.0.0
  • 4784dfd Merge branch 'master' into ms-3.0.0
  • 7b48ad4 TypeScript rewrite, v3.0.0
  • 48aaf58 Merge pull request #41 from openseadragon-imaging/dependabot/npm_and_yarn/fas...
  • d0aef2e Bump fast-uri from 3.1.0 to 3.1.2
  • af95bbf Merge pull request #40 from openseadragon-imaging/dependabot/npm_and_yarn/pos...
  • f6e7054 Bump postcss from 8.4.31 to 8.5.10
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@openseadragon-imaging/openseadragon-viewerinputhook](https://github.com/openseadragon-imaging/openseadragon-viewerinputhook) from 2.2.1 to 3.0.1.
- [Changelog](https://github.com/openseadragon-imaging/openseadragon-viewerinputhook/blob/master/CHANGELOG.md)
- [Commits](openseadragon-imaging/openseadragon-viewerinputhook@v2.2.1...v3.0.1)

---
updated-dependencies:
- dependency-name: "@openseadragon-imaging/openseadragon-viewerinputhook"
  dependency-version: 3.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 1, 2026
@vercel

vercel Bot commented Jun 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
universalviewer Ready Ready Preview, Comment Jun 1, 2026 1:36am
universalviewer.dev Ready Ready Preview, Comment Jun 1, 2026 1:36am

Request Review

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the changelog, I'm reasonably confident that there aren't relevant breaking changes here, and I don't see anything obviously wrong (plus tests are passing). However, it looks to me like the viewer input hook is only used in one very specific place, and I'm not sure how to test that code, so I'm not going to merge this right away. If anyone else can weigh in, I'd appreciate it!

@LanieOkorodudu

Copy link
Copy Markdown
Contributor

Based on the changelog, I'm reasonably confident that there aren't relevant breaking changes here, and I don't see anything obviously wrong (plus tests are passing). However, it looks to me like the viewer input hook is only used in one very specific place, and I'm not sure how to test that code, so I'm not going to merge this right away. If anyone else can weigh in, I'd appreciate it!

@demiankatz I based my manual testing on my understanding of the "one very specific place" you mentioned. It appears that viewerinputhook is used to handle the viewer's double-click input, so I verified the related viewer interactions by checking panning, zooming, and double-clicking on the image. Everything behaved as expected, and I didn't see any console errors with this dependency upgrade. If I've misunderstood what it actually does, so please let me know if there's another behaviour I should be testing.

@demiankatz

Copy link
Copy Markdown
Contributor

@LanieOkorodudu, the one specific place I mentioned only seems to do something if the doubleClickAnnotationEnabled config is turned on, and I'm not really sure what that setting does. The config docs say "Determines if annotation is enabled" with a default of false, but that doesn't really tell me what behavior I should expect to see, or what kind of manifest is needed to trigger that behavior. In any case, I think we need to figure that out and test it before we can merge this. We should probably clarify the documentation as well once we have an understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

Status: In testing

Development

Successfully merging this pull request may close these issues.

2 participants