Skip to content

docs(overview): fix "Capabilities Incompatible" examples to use capabilities_incompatible#562

Merged
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
vishkaty:fix/overview-capabilities-incompatible-example
Jul 7, 2026
Merged

docs(overview): fix "Capabilities Incompatible" examples to use capabilities_incompatible#562
damaz91 merged 1 commit into
Universal-Commerce-Protocol:mainfrom
vishkaty:fix/overview-capabilities-incompatible-example

Conversation

@vishkaty

@vishkaty vishkaty commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Both examples headed "Capabilities Incompatible" carried "code": "version_unsupported" (with version-failure content), contradicting the negotiation-errors table where capabilities_incompatible200. This corrects the code and content in both the REST (200 OK) and JSON-RPC (result) examples.

The three legitimate version_unsupported examples ("Version Unsupported" headings + the prose example) are untouched.

Closes #560. Found while building an unofficial UCP conformance suite (https://spck.dev).

@vishkaty vishkaty requested review from a team as code owners July 3, 2026 18:17
@vishkaty vishkaty requested review from alexpark20 and yanheChen July 3, 2026 18:17
@google-cla

google-cla Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vishkaty

vishkaty commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@vishkaty vishkaty closed this Jul 3, 2026
@vishkaty vishkaty reopened this Jul 3, 2026
…ilities_incompatible

Both examples headed "Capabilities Incompatible" carried `"code":
"version_unsupported"` with version-failure content, contradicting the
negotiation-errors table (capabilities_incompatible -> 200). Correct the code and
content in both the REST and JSON-RPC examples; the legitimate "Version Unsupported"
examples are unchanged.

Fixes Universal-Commerce-Protocol#560
@vishkaty vishkaty force-pushed the fix/overview-capabilities-incompatible-example branch from 80018cb to 9d6e262 Compare July 3, 2026 18:31
@damaz91 damaz91 merged commit 9b348f8 into Universal-Commerce-Protocol:main Jul 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overview.md: "Capabilities Incompatible" examples carry code: version_unsupported, contradicting the error-code table

4 participants