Skip to content

chore: Up-port from develop-2.0.0 from week 32/33 - #4141

Merged
michalChrobot merged 8 commits into
develop-3.x.xfrom
up-port-develop-3-x-24-08
Aug 31, 2026
Merged

chore: Up-port from develop-2.0.0 from week 32/33#4141
michalChrobot merged 8 commits into
develop-3.x.xfrom
up-port-develop-3-x-24-08

Conversation

@michalChrobot

@michalChrobot michalChrobot commented Aug 24, 2026

Copy link
Copy Markdown
Member

Purpose of this PR

PR that up-ports PRs that landed during last 2 weeks or otherwise since we did the last up-port.
Note that I won't "squash and merge" and I will rather merge them separately as then in the future it will be easier to reason about PRs history.
Also not all commits are ported because some of them were up-ported already (picture shows the range of commits I was evaluating)

image

Jira ticket

N/

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

Green CI

Up-port

This is an up-port

Backports

N/A

EmandM and others added 6 commits August 24, 2026 14:00
* fix: GC allocations

* Add message receive allocations test

* Revert the fix to check ILPP build fails the test

* Revert forced failure

* Remove gc checks on NetworkListTests
* Re-enabled ps5 and webgl

* ci: Add WebGL PlayMode test job (MTT-15569)

Split the WebGL CI into a build phase and a run phase. webgl-build.yml
now exposes the built player as a dedicated 'players' artifact, and a new
webgl-test.yml run job consumes it and executes the PlayMode tests inside
Firefox on a GPU-backed Ubuntu agent (Unity::VM::GPU, rtx2080). The Firefox
browser flags are passed explicitly so UTR does not attempt to download the
browser from Stevedore.

The run job is wired into the Nightly and Weekly (QV) triggers only, not
into PR triggers, since WebGL failures are infrequent and the build is slow.
Runtime RuntimePlatform.WebGLPlayer exclusions are intentionally deferred to
be added reactively after the first real CI run.

* corrected images

* disabled webgl test

* adjustments

* Removed WebGL changes

* reverted change

* added diagnostic for switch

* corrected Switch sdk version

* temporarily disabled switch

* corrected ticket description
Changde users exclusion to pattern exclusion in pr description check
* Updated changelog and package version for Netcode in anticipation of v2.13.1 release

* typo in build automation

* trunk shadow changes: com.unity.netcode.gameobjects [skip ci]

* Revert CHANGELOG changes

* Added UNITY_TEST_FRAMEWORK_1_7_OR_NEWER guard and UnityCoreClrExplicitDisabledAttributeShim.cs to make attribute usage possible

* corrected svc bot exclusion

---------

Co-authored-by: netcode-automation <svc-netcode-sdk@unity3d.com>
Co-authored-by: Michał Chrobot <michal.chrobot@unity3d.com>
Co-authored-by: PETS automation <299490404+pets-svc[bot]@users.noreply.github.com>
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Co-authored-by: unity-renovate[bot] <120015202+unity-renovate[bot]@users.noreply.github.com>
@cla-assistant-unity

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michalChrobot michalChrobot changed the title Up port develop 3 x 24 08 chore: Up-port from develop-2.0.0 from week 32/33 #4116 Aug 24, 2026
@michalChrobot michalChrobot changed the title chore: Up-port from develop-2.0.0 from week 32/33 #4116 chore: Up-port from develop-2.0.0 from week 32/33 Aug 24, 2026

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The allocation-focused runtime changes are generally coherent, but the new integration coverage is not excluded from a known failing CoreCLR configuration and two diagnostic/validation changes alter behavior incorrectly.

Reviewed commit c30cbc3

🤖 Helpful? 👍/👎

Comment thread .github/workflows/pr-description-validation.yml Outdated
@codecov-github-com

codecov-github-com Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...eobjects/Runtime/Messaging/Messages/RpcMessages.cs 0.00% 2 Missing ⚠️
@@                Coverage Diff                @@
##           develop-3.x.x    #4141      +/-   ##
=================================================
- Coverage          78.02%   78.00%   -0.02%     
=================================================
  Files                153      153              
  Lines              26260    26264       +4     
=================================================
- Hits               20489    20487       -2     
- Misses              5771     5777       +6     
Flag Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk 77.62% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../Messaging/Messages/NetworkVariableDeltaMessage.cs 77.92% <100.00%> (ø)
...objects/Runtime/Messaging/NetworkMessageManager.cs 82.39% <100.00%> (ø)
...netcode.gameobjects/Runtime/Metrics/MetricHooks.cs 100.00% <100.00%> (ø)
...Runtime/NetworkVariable/Collections/NetworkList.cs 79.75% <100.00%> (-0.07%) ⬇️
...ode.gameobjects/Runtime/Serialization/BitReader.cs 94.23% <100.00%> (ø)
...eobjects/Runtime/Serialization/FastBufferReader.cs 80.03% <100.00%> (ø)
...eobjects/Runtime/Messaging/Messages/RpcMessages.cs 42.61% <0.00%> (+0.94%) ⬆️

... and 1 file with indirect coverage changes

Components Coverage Δ
com.unity.netcode.gameobjects 78.00% <93.33%> (-0.02%) ⬇️

ℹ️ Need help interpreting these results?

@michalChrobot
michalChrobot merged commit 17704cf into develop-3.x.x Aug 31, 2026
26 of 28 checks passed
@michalChrobot
michalChrobot deleted the up-port-develop-3-x-24-08 branch August 31, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants