Fix StringLocker behavior. - #1588
Open
zliebowitz wants to merge 1 commit into
Open
Conversation
|
|
Author
|
This pull request demonstrates the issue (via test) and fixes via fixing StringLocker. I'm not sure if you'd rather go after this issue in a different fashion (removing the StringLocker), but I figure this at least shows the bug pretty directly. |
lesserwhirls
requested changes
Jul 28, 2026
lesserwhirls
left a comment
lesserwhirls
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution! Overall the changes look great! Just a few comments regarding the tests.
zliebowitz
force-pushed
the
fix-stringlocker-behavior
branch
from
July 28, 2026 23:16
c8ad1f7 to
ce1a9b4
Compare
zliebowitz
force-pushed
the
fix-stringlocker-behavior
branch
from
July 31, 2026 01:12
ce1a9b4 to
2e7c91a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix issues that could break mutual exclusions properties desired in StringLocker.
PR Checklist
until ready for review