Zenodo fix #761
Merged
Merged
Conversation
…version Zenodo stopped updating at v1.57.1 (June 2025) while the project shipped v2.4.0, because the API-based `publish-zenodo` job meant to do the syncing never worked and was commented out in 744d5a8, leaving no path at all; Zenodo's own GitHub integration is now enabled, and it webhooks the `release: published` event and mints a new version under the existing concept DOI without any job, token, or API call of ours, so this strips the dead job from `publish-pypi.yml` along with `tools/release/publish_zenodo.py` and `tools/release/sync_citation.py` (the `ZENODO_ACCESS_TOKEN` secret can now be revoked). It also removes `version` and `date-released` from `CITATION.cff`: the git tag is already the single source of truth, since setuptools_scm derives the package version from it and Zenodo takes the archive version and date from the release, so restating them here meant hand-editing the file on every release -- precisely how it drifted to 2.1.5 while 2.4.0 was current. Both fields are optional in CFF 1.2.0 and the file still validates against the schema. `test_release_metadata.py` now guards the invariants that actually matter (concept DOI pinned, no version restated, no `.zenodo.json`, no second API-based sync path) and matches only uncommented workflow lines, since the old assertion for `sync_citation.py` had been passing against commented-out YAML for months. Note that the integration only archives releases published after it was enabled and never backfills, so v2.4.0 will not appear retroactively; the next tagged release is what will bring Zenodo current.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zenodo stopped updating at v1.57.1 (June 2025) while the project shipped v2.4.0, because the API-based
publish-zenodojob meant to do the syncing never worked and was commented out in 744d5a8, leaving no path at all; Zenodo's own GitHub integration is now enabled, and it webhooks therelease: publishedevent and mints a new version under the existing concept DOI without any job, token, or API call of ours, so this strips the dead job frompublish-pypi.ymlalong withtools/release/publish_zenodo.pyandtools/release/sync_citation.py(theZENODO_ACCESS_TOKENsecret can now be revoked). It also removesversionanddate-releasedfromCITATION.cff: the git tag is already the single source of truth, since setuptools_scm derives the package version from it and Zenodo takes the archive version and date from the release, so restating them here meant hand-editing the file on every release -- precisely how it drifted to 2.1.5 while 2.4.0 was current. Both fields are optional in CFF 1.2.0 and the file still validates against the schema.test_release_metadata.pynow guards the invariants that actually matter (concept DOI pinned, no version restated, no.zenodo.json, no second API-based sync path) and matches only uncommented workflow lines, since the old assertion forsync_citation.pyhad been passing against commented-out YAML for months.Note that the integration only archives releases published after it was enabled and never backfills, so v2.4.0 will not appear retroactively; the next tagged release is what will bring Zenodo current.