Repository navigation
Fix ASV references to mamba - #1898
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
Running the three different workflows against this PR to confirm whether they are fixed:
I'll give a full review once these all finish! |
The PR benchmark workflow failed in Setup with "Could not find 'conda' in PATH": asv.conf.json uses environment_type "conda", so asv shells out to a conda executable, which micromamba does not provide. `mamba` in create-args used to pull conda in, but mamba 2.x is a standalone binary that no longer depends on it. mamba itself was only needed while environment_type was "mamba" (#831, switched back to "conda" in #844); asv 0.6.6 has no mamba backend. Install `conda` instead of `mamba`, and drop `python-build`: asv builds the wheel in its own env, where the asv.conf.json matrix provides it. asv's faster "rattler" backend was considered, but it passes the `nodefaults` entry of ci/environment.yml to the solver as a real channel and fails fetching conda.anaconda.org/nodefaults. `nodefaults` stays: it is what keeps uxarray_build defined by the repo alone, not by a user's .condarc. Also: - ci.yml link-check and upstream-dev-ci.yml set up with micromamba but ran `conda list`, which micromamba cannot satisfy; use `micromamba list`. - asv.conf.json: list the environment types asv 0.6.6 actually has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cmdupuis3
force-pushed
the
cmd/ci-fix
branch
from
November 13, 2026 18:19
618899f to
0ff23fe
Compare
Collaborator
Author
|
@Sevans711 Okay np, I've been trying a few different approaches, so make sure you're using the latest code. I was looking at potentially using rattler, but for now it's just a quick fix. |
cmdupuis3
changed the title
ASV BenchmarkingBenchmark Comparison ResultsBenchmarks that have stayed the same:
Benchmarks that have got worse:
|
Sevans711
approved these changes
Nov 13, 2026
Sevans711
left a comment
Sevans711
left a comment
Collaborator
There was a problem hiding this comment.
Simple-looking changes touching only a few lines, and I'm seeing successful runs in ASV, CI, and Upstream CI now (links in my previous comment), so I'm happy to approve. Thank you for handling this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1897
Overview
The PR benchmark workflow failed in Setup with "Could not find 'conda' in PATH": asv.conf.json uses environment_type "conda", so asv shells out to a conda executable, which micromamba does not provide.
mambain create-args used to pull conda in, but mamba 2.x is a standalone binary that no longer depends on it. mamba itself was only needed while environment_type was "mamba" (#831, switched back to "conda" in #844), and asv 0.6.6 no longer has a mamba backend.PR Checklist
General
Testing & Benchmarking
Documentation and Examples
AI Disclosure
AI Usage: