Repository navigation
Conversation
…ibility ownership
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source Gen2 battle model lacks its public round clock, and native battler data construction is coupled to picture/animation allocation. Expose the existing native counter (initially zero) and extract data construction into Battler.new; BattleState.makeBattler hydrates that same table through the existing sprite and animation factories. There is no second round counter, RNG stream, turn simulator, copied party Pokemon or replacement artwork.
This is a stacked draft on the separately offered model/RNG/friendship work (#395, #394 and their listed prerequisites). Party/move/stat/registry identities, badges, sleep, form-personal records and the older host's existing Gen2 bindings/poison defaults are retained. It does not depend on the newer fork-only HeldItemRead module.
Validation:
The latest offered head67a05ea1 adds documentation to the tested extraction. Complete current combined-host/regression/GPU qualification remains pending; the previous complete older-host baseline had11 unrelated existing failures. This draft does not claim upstream CI is green, full source Battle.new/standalone turn execution, arbitrary writable model fields, complete unchanged-VASC presentation or release acceptance. No mod changes and no upstream merge is performed.
Contributions by Roxas2712. The extracted engine data retains original authors' rights and applicable licences. The integration/tests are offered under https://github.com/Roxas2712/Gen2Recomped/blob/main/LICENSE-ROXAS2712.md including its specific permission for Cedric/UNDERdecoded with visible credit; https://github.com/Roxas2712/Gen2Recomped/blob/main/NOTICE.md retains provenance. These terms do not replace earlier permissions or assign ownership of the underlying engine.