Repository navigation
Conversation
…stream-gen2-palette-clock
…nto codex/upstream-gen2-palette-register
…ck real SDK entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native GSC Pokemon still carry numbered importer placeholders into unchanged consumers. A model catalog keyed by
CYNDAQUILcannot selectSPECIES_155merely because a named dataset lookup exists.Publish one canonical named native Gold/Silver/Crystal graph before mods/game objects. Keep numbered lookup/edit aliases on the real registry and constructor, normalize old save identities at native validation, and resolve script byte operands/numeric writeback through the same dataset. Preserve upstream's existing loader/controller policies; partial/authored datasets and other cartridge address spaces are not reinterpreted.
This draft is cumulative after #366 and its documented dependency stack (#202, #356–#365). The incremental change is the native GSC identity graph, alias-aware registry seam, script/breeding/save adapters and ROM-free tests. It does not import the fork's unrelated launcher/renderer/foundation files. No mod changes are required or included.
Validation: 27 frozen upstream native/shared suite groups pass, including 3,230 runtime/save checks and 84 native script/breeding checks. The fork counterpart is Roxas2712/Gen2Recomped#285. Native model-selector evidence and actual fork GPU observations are separate from this upstream CPU qualification; this draft does not claim full unchanged-mod, Windows or release readiness.
Original contributions by Roxas2712. Offered to Cedric / UNDERdecoded under the specific PR contribution permission in LICENSE-ROXAS2712.md; retain its visible contribution credit and existing upstream/third-party notices. Existing broader permissions remain effective.