Repository navigation
Conversation
Roxas2712
marked this pull request as ready for review
October 26, 2026 00:10
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F11 currently cannot separate tile-window maintenance, native world phases, zone composition, voxel passes and DS audio mixing. Add nested FrameProfile sections at those native work sites, preserving drawing order, callback arguments and error cleanup. Disabled profiling uses the existing shared no-op closer.
Independent patch against main 13af468; no pending feature stack is included. Main sites: src/world/OverworldController.lua:16682, src/render/TileRenderer.lua:1797, src/render/Renderer.lua:690 and :1400, src/audio/NitroAudio.lua:198, mods/DRAMATIC_SHAPE/lib/VoxelScene.lua:2673, :2684, :2777 and :2876. docs/frame-profile-sections.md explains scope and nesting.
Validation:
FrameProfile desktop before/after: not measured. ARM/device timings: not measured. This adds observability and makes no performance claim. Disable with F11 / FrameProfile.setEnabled(false).
The acceptance repairs are offered separately in #102 and the named import diagnostics in #274. Integrated fork main 61f1d5d passes 416/416 engine suites, 3/3 SDK suites, the 253-check gallery, and 200 contract comparisons / 400 isolated loader runs against pinned 535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91. Authenticated external fixtures load 13/14 entrypoints; the allowed M1–M4 intermediate gate records the remaining exact named sprite-module gap. Complete follower acceptance is still open. These composed results do not imply that this standalone patch contains the acceptance prerequisites.
Original additions by Roxas2712 are offered to Cedric / UNDERdecoded under the specific PR permission in https://github.com/Roxas2712/Gen2Recomped/blob/4fb81fbf/LICENSE-ROXAS2712.md, with visible contributor credit. Existing rights, notices and credits remain effective.