Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native GBA menu modules currently have no modal stack in this engine. This adds
src.ui.game3.stackas a view over the realStateStack: menus keep their actual native owners, input, enter/exit callbacks and screen events while world and battle controllers remain outside the modal plane.Named close/reopen, nested draw ordering, fullscreen predicates and preview suspension/restoration use those same states. Preview leases reject retired states, another map, another save or another session, including copied layer arrays. GBA widgets request their actual 240×160 surface. Main-screen mirroring still respects
screen.render_visiblewithout changing input ownership.Depends on #146 (portable screen visibility); the branch starts at its pushed head. It contains no Gen2 persistent-world, battle-view or mod-port changes. No private mod source, game data or ROMs are included.
Validation:
535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91and this fork, separately for FireRed and Emerald; equal results. CI pins the reference.Source-bound GPU and scope receipt. The public preview release remains unchanged.