Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a native queued callback or HP drain finishes, zero-valued transient markers remain on the battle state. Consumers that correctly require a settled command boundary then stay blocked for the rest of the battle.
Retire the insertion cursor after each successful callback and when an externally inserted queue runs out. Keep the cursor present during callback execution so reentrant consumers remain blocked. Retire a completed HP closing hold on the existing idle frame, preserving the drain and closing-frame timings.
Validation: 144/144 native lifecycle checks across Red, Gold, Silver, Crystal, FireRed and Emerald, including nested insertion order and external UI insertions; the unchanged parent fails the same regression. The independent branch also passes 163/163 timing and 18/18 multihit-drain checks. No ROM or mod assets are included.
The combined fork additionally exercises the actual START auxiliary hook after queued callbacks and HP drains: 4,680/4,680 checks across the existing game/API matrix. That hook is supplied separately by #152.