Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beat Up currently selects only the active trainer's party. In a two-trainer or player/ally battle, native Gen1Recomp execution reads the entire side party: six eligible members contribute six hits even when the user belongs to the second trainer.
Read primary slots followed by partner slots through a private live view. Keep the owning arrays and replacement benches separate. Honor the battle-scoped player party, current user's live HP/status, and replacement of an upcoming bench member inside a public hit callback. Capture the current array references for the move, matching the reference when whole party fields are reassigned mid-move.
Stacked on #209. Review c2a1a03 relative to 03d68a4.
Validation:
These are native actions and constructors with synthetic imported-shaped parties, not a graphical playthrough or a full link/multi-owner controller claim. A scoped player view and detached active battler are seeded explicitly; no new selection/replacement API is introduced. Full raw RNG traces, arbitrary mid-move ownership reshaping, intros/animations, other scripted executors and complete gameplay remain separate acceptance surfaces. Gen1 stays read-only, with no source edit or publication.
Combined full-suite acceptance and hosted CI are reported below.
Hosted CI: all six workflows for c2a1a03 report action_required pending maintainer approval. The dedicated contract run has zero executed jobs. Local acceptance is separate.
Combined-fork acceptance: integrated into Roxas2712:codex/portability-testing. Clean runtime f39cc19 passes 217/217 engine suites, 3/3 SDK suites and B30 with zero FAIL lines. The same clean runtime passes all 48 workers / 4,766 paired observations. Integration updates only the audited move_effects section pin; the fingerprint gate passes 33/33 checks, including the unchanged sections and mutation checks. Subsequent combined commits only record validation.