Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning {move = "SCRATCH"} from battle.enemy_action currently produces no move on GBA, while {id = "SCRATCH"} can reach PP subtraction with no PP value and crash. Bare names/numbers also get rejected by the unified callback boundary. Normalize these choices against the active dataset and bind execution PP to the selected native move slot.
The change preserves learned move IDs, duplicate-slot selection, Pressure costs, Mimic slot ownership, native charge continuation identity, legacy delegated id edits, unchanged delegated handles, and native special actions. Nil/false/unknown choices use the captured native fallback. Other generations and record boundaries retain their current validation.
Stacked on #102 (API-3 entry). The isolated feature is commit 64068911: 12 files, including focused fixtures, the same public consumer on both engines, a pinned read-only contract checker, documentation and CI.
Validation:
Scope: GBA move-result normalization. The second hook argument, native action fields, public item/switch/watch records, explicit double-target conversion, damage arithmetic and RNG-trace parity are separate contracts. No Gen1 patch or publication is required. Hosted CI results will be reported separately from local validation.
Combined-fork validation: cherry-picked into
Roxas2712:codex/portability-testing, production runtime fbd10fa. All 208/208 engine suites, 3/3 SDK suites and B30 pass; the same 8-worker / 100-observation cross-engine contract passes on this runtime too. The combined callback boundary retains the existing three-argument restore contract.Hosted CI: all three workflows report
action_requiredpending maintainer approval. The dedicated contract workflow has zero executed jobs; these are not hosted green results.