Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A portable mod registering an AI class with
item = "POTION"currently leaves that symbolic name in Gen2Recomped's native registry. Imported Gen-2/GBA data uses keys such asITEM_018orITEM_013, so the same mod fails reference validation. AI-class read/write results also bypass the detached unified-content boundary.Resolve optional class item references through the mounted item registry before recording operations, and project common IDs in detached
get,each,register,overrideandpatchresults. Keep native schemas, rollback, deletion and load-time freezing authoritative. Add one unchanged public example, real-loader contract fixtures, an isolated imported-data smoke driver, documentation and a pinned cross-engine CI workflow.This is stacked on #173 as part of the portability series; the incremental scope is the AI-class content adapter and its tests/documentation. It does not enable the unfinished
battle.enemy_switch_or_itemhook or claim identical native AI behavior.Compatibility
Validation
535a5ec088c1ae1bf4d91dd3e35a56f64cf46d91.The incremental changes relative to #173 are available separately for review.
The combined
Roxas2712:codex/portability-testingruntime4975ca8337faa27dde511fa5c6cb93c6210c7bab, including the separate baseline repairs, passes 194/194 engine suites, 3/3 SDK suites and B30. Both shared contract modes and the four imported-data metadata smoke sessions also pass at that clean runtime. Later commits only record validation documentation.All 34 hosted PR workflows currently report
action_requiredpending maintainer approval. The AI-class content workflow has zero executed jobs; these hosted results are not presented as passing CI.