Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mods cannot currently control Gen2Recomped's already-caught enemy marker through the shared
battle.caught_marker_visiblehook. Add the native producer and marker rendering for classic/wide GB and GBA singles.Only literal true shows the marker. Preserve the reference defaults (Gen 1 off; Gold/GBA on), ownership/wild-battle eligibility, Gold's encounter-entry latch, GBA tutorial/ghost/status/doubles exclusions and GBA presentation caching. API 3 and the host's API-2 unified mode use context views; native callbacks retain their original shapes. DS reports unavailable.
New GBA imports read native healthbox tile 70 separately from the existing bounded 66-tile status scan. Existing caches use their Pokédex marker, cropping the older tall Emerald cell to the central 8×8 footprint. Include a public consumer, documentation, a pinned cross-engine checker and CI.
Validation
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. API-2 unified tests exercise the host adapter against reference native callbacks.650467e7bea28eee1dd6e2dc967b566dc3429ce6: 173/173 engine suites, SDK 3/3 and B30 passed. Feature full-suite refbd182e0f4c39df69f86bcc76ceb15a51e1330579: 118/128 suites with exactly the ten unchanged baseline failures addressed separately in test: repair Gen2 updater asset fixtures #128–134; SDK 3/3 and B30 passed.40e3e1219e05dd3f675fddcc01c7b1b0f92593ab: the same installed API-3 consumer, actual HUD rendering and pixel readback for visibility/defaults, ownership/trainer/status/hidden-HUD gates and unsubscribe. Saved HUD images were inspected. Isolated identity, constructed battles and no normal SAVE. These use existing cache artwork/fallbacks; complete fresh-ROM reimports, cross-engine pixel equality and full playthroughs are not claimed. The new dedicated tile path is verified with synthetic ROM bytes through the real reader/decoder.Scope and review
The argument remains a native screen/state context; this does not normalize private battle-controller internals. GBA retains the verdict until its healthbox presentation changes, including after option changes or unsubscribe.
Prerequisite: #162 and its API/native-hook stack. The series targets main; feature-only changes.
Feature head:
b1c8e7e76b3e23a591e0f26635ca2867ec6d5f89. Shared reports are pinned to the full-suite refs above; native GPU smoke retains its separate historical ref. No cartridge art/data or private mod is bundled. Hosted CI results are separate from local validation.Published combined testing branch:
7ef9983a278509c33068e9fb2e27c3ec0d1ba1e9; changes after the recorded full-suite runtime are bytecode-equivalent fixture formatting and validation documentation/status only. All 24 hosted #163 PR workflows reportaction_requiredpending maintainer approval; the new caught-marker workflow has zero jobs. Hosted CI has not executed; local results above are separate.