Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen2Recomped accepted
core.logic_speedregistrations without a native producer, so portable speed-control mods could load successfully while having no effect. Dispatch the same(next, game)contract as Gen1Recomp through native API 1/2, unified API 2 and API 3.next()ornext(otherGame), then clamp the first hook result to the existing Gen2 speed ladder. Preserve the global saved speed and explicit launch overrides.isFixedSpeed/isMinigamelocks before overrides or callbacks. If a lock begins during an accelerated step, cancel the remaining frame budget without triggering hitch suppression.Stack / review scope
Depends on #144 and its existing prerequisites. This branch adds one feature commit on top of
34d5c10ff5cf5c8c65170a339a0ba9504972bf40; the main-target diff includes those unmerged prerequisites. Review only this change.Validation
Game:loadcallback /Game:update/FixedStepclock checks (407). Updated capability suite: 346/346.79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. Tests preserve native ladder differences (including Gen1's 3X rung), Gen1 GBA boot precedence, explicit next-target routing, invalid results, wrapper/native errors, cleanup and no-mod fallback.The feature has the same ten failing suites and 17 failing assertions as its parent, with identical failure output; no new regression. Those separately proposed baseline fixes are included in the combined integration at
d01a9ea2ba59146531cf007a39e9cee6a9c74d9f. The integration needed only a documentation placement resolution.Reproduction commands and fixture boundaries are in the contract document. StyLua, actionlint and diff whitespace checks pass. Validation is ROM-free/headless; cartridge playthroughs, GPU rendering and live network sessions are outside these checks.
Hosted CI
GitHub currently reports
action_requiredfor all 6 pull-request workflows; jobs await maintainer approval for the fork contribution. These are not hosted passes. New logic-speed contract run. Local results above were completed on the published feature head and the combined integration.Integration follow-up: the native clock fixture now also supplies the map-metadata and tileset-publication startup dependencies from #205/#208. Its real FixedStep/clock assertions remain in place; all 407 checks pass independently on this branch.