Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen2Recomped currently never dispatches
input.key,input.gamepadorinput.wheel, so portable overlays must replace engine methods to capture these events. Add the native Gen1Recomp hook contracts at the six existing Game callbacks, together with capability and unified callback catalog entries for API 2/3.Depends on #102 and its public-API prerequisites. Merge those first and rebase before merging. The input work is one commit; implementation-only diff. It does not depend on the rendering or shader PRs.
Wrappers receive the original Game/joystick handles, key/button press and release payloads, axis values, or the vertical wheel delta. Omitting
nextsuppresses the normal callback, including hotkeys/capture, held-state changes, axis transitions and wheel zoom. Native bodies are preserved verbatim in private helpers. When no chain is installed, dispatch skips the bus, payload and continuation allocation. As in Gen1, rewriting continuation arguments affects downstream wrappers while native processing retains the original event.Includes a generic overlay example, release-ownership documentation, ROM-free tests and a dedicated cross-engine workflow pinned to clean Gen1Recomp
79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. The reference engine is never patched.Validation:
Integration preserves the newer pointer/render catalog entries when resolving the two catalog-line overlaps. ROM-dependent tiers were skipped because no imported data is present. This is a headless contract/routing test, with no hardware gamepad or OS event-delivery claim.
Hosted workflows currently require maintainer approval (
action_required): API 3 contracts, ci, portable input hook contract. No hosted pass is claimed.