Repository navigation
Conversation
# Conflicts: # src/mods/Loader.lua
# Conflicts: # docs/modding.md # src/mods/Loader.lua # src/world/WorldAPI.lua
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #103 and its API prerequisites (#102, #90–#99), which remain open and are included as ancestors. Merge those first, then rebase before merging this PR. The implementation is isolated in
2ea78e3db7a07532c6ab08a2c0cd0e7b7edeee5d(implementation-only diff). No shader dependency is added.Behavior
API-3 mods currently receive unsupported results for
mod.world:toggleObject()andmod.world:replaceBlock()despite existing native paths. Enable both for generations 1–3 with validation and native idle-world admission. Invalid arguments, malformed target stores, missing runtime geometry/redraw services and busy world owners decline before native effects. API-3 Gen4/5 remain unavailable; API-1/2 facade behavior and the portable script vocabulary are unchanged.Preserve native generation semantics: Gen1 visibility keys may target inactive maps; Gen2/3 resolve active-map templates and use native visibility effects, including persistent event flags and visit-scoped flagless state. Extract Gen2's existing appear/disappear effect into a shared native helper so public template resolution does not depend on cached script-object numbering. Targeted synchronization leaves unrelated live actors in place, including actors sharing a flag.
Validate zero-based block coordinates and IDs (Gen1/2: 32px blocks, IDs 0–255 present in the tileset; Gen3: 16px metatiles, IDs 0–1023). Replace through the host's native block/metatile paths, including Gen3's default collision/shut-cell reset and redraw. Emit one native-shaped public event per successful edit. Gen2Recomped retains instance patches without rewriting generated map data.
Reuse the API-3 owner lease from #103: rollback, reload and teardown retire retained mutation facades. Decline reentrant edits during an edit's own event/native callback; release the guard on both success and exceptions. Native failures after entering a mutation are not transactional rollbacks.
Reference routing, persistence, geometry and reproduction. This does not invent common map/object IDs or a shared collision table.
Validation
bryanthaboi/gen1recomp@79ea62f45fb2ea8f65d081a109431e4eb1bbdb36. The same new fixture manifest/source runs through both real loaders for Red, Blue, Yellow, Gold, Silver, Crystal, FireRed and Emerald. All previous entry, rollback, generated-starter and warp cases remain. Reports include fixture hashes and the tested clean feature head.world_editsmode.The ten unchanged failing engine suites are
gate_fingerprint,gate_meta_coverage,quit_thread_shutdown,rebind_capture_bug510,rebind_swap_clear_bug589,soft_reset_bug563,tool_mod_hooks,update_check_tests,update_testsandwide_battle_layout.Hosted CI: API 3 contracts and ci currently report
action_requiredand await maintainer approval for the fork workflows. All local results above were run against the published source; no hosted green result is claimed.