Skip to content

[ui5-tokenizer: incorrect overflow calculations]: #14067

Description

@niyap

Bug Description

With the following change: 13857 we have introduced a deviation in the overflow calculations. In some scenarios where previously the first token was shown and then n-more indicator, now it is changed to "N items" but actually the space is enough if we follow the specification to show the first token and N-more label.

You can check the visual tests for reference as well since some of them are failing with the same issue.

Affected Component

ui5-multi-combobox, ui5-multi-input, ui5-tokenizer

Expected Behaviour

When there is enough space, first token should be visualised and then followed by N-more label for the overflowed ones.

Isolated Example

https://ui5.github.io/webcomponents/components/MultiComboBox/

Steps to Reproduce

  1. Open the sample
  2. Check "Basic Sample" and select Bulgaria as well

...
2 items is shown, previously: Argentina 1more

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

latest

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions